Merge pull request #136 from a4lg/more-portable-ratios

jonjoliver · web-flow · commit 809279e5477f · 2024-10-08T15:40:13.000+11:00
Bug Fix+Portability: Improve portability by integral division
diff --git a/src/tlsh_impl.cpp b/src/tlsh_impl.cpp
@@ -784,8 +784,8 @@ void TlshImpl::final(int fc_cons_option)
     }
     
     this->lsh_bin.Lvalue = l_capturing(this->data_len);
-    this->lsh_bin.Q.QR.Q1ratio = (unsigned int) ((float)(q1*100)/(float) q3) % 16;
-    this->lsh_bin.Q.QR.Q2ratio = (unsigned int) ((float)(q2*100)/(float) q3) % 16;
+    this->lsh_bin.Q.QR.Q1ratio = (unsigned int) ((unsigned long long) q1 * 100 / q3) % 16;
+    this->lsh_bin.Q.QR.Q2ratio = (unsigned int) ((unsigned long long) q2 * 100 / q3) % 16;
     this->lsh_code_valid = true;   
 }
 

Original file line number	Diff line number	Diff line change
`@@ -784,8 +784,8 @@ void TlshImpl::final(int fc_cons_option)`
`784`	`784`	`}`
`785`	`785`
`786`	`786`	`this->lsh_bin.Lvalue = l_capturing(this->data_len);`
`787`		`- this->lsh_bin.Q.QR.Q1ratio = (unsigned int) ((float)(q1*100)/(float) q3) % 16;`
`788`		`- this->lsh_bin.Q.QR.Q2ratio = (unsigned int) ((float)(q2*100)/(float) q3) % 16;`
	`787`	`+ this->lsh_bin.Q.QR.Q1ratio = (unsigned int) ((unsigned long long) q1 * 100 / q3) % 16;`
	`788`	`+ this->lsh_bin.Q.QR.Q2ratio = (unsigned int) ((unsigned long long) q2 * 100 / q3) % 16;`
`789`	`789`	`this->lsh_code_valid = true;`
`790`	`790`	`}`
`791`	`791`